Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License malformed #225

Closed
namazso opened this issue Nov 7, 2022 · 0 comments
Closed

License malformed #225

namazso opened this issue Nov 7, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@namazso
Copy link

namazso commented Nov 7, 2022

the LICENSE file's text was probably mangled by some copypasting from secondary, reformatted sources. This causes both GitHub (see on the right saying "View license" rather than Apache 2) and tools like cargo-about to not recognize the license. I'd recommend replacing the file with the canonical text so that tools can parse it better

Also, you aren't supposed to fill out your name in the bottom "APPENDIX: How to apply the Apache License to your work." part. Instead, the convention is to shove the unmodified file into the repo as LICENSE / COPYING or something similar, then only put the notices into the source files, README, and/or a separate LICENSE / COPYING file with only that content.

@zkat zkat added the bug Something isn't working label Nov 24, 2022
@zkat zkat closed this as completed in d5fbb34 Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants