Skip to content
This repository has been archived by the owner on Jul 6, 2019. It is now read-only.

Fix typos in french locale #78

Merged
merged 1 commit into from
Jul 12, 2017
Merged

Fix typos in french locale #78

merged 1 commit into from
Jul 12, 2017

Conversation

AntoineReneleau
Copy link
Contributor

No description provided.

@gorhgorh
Copy link
Contributor

Thanks for the corrections and review :) I'm feeling better not being alone on this,

little detail, I don't totally agree with your last edit

"npx: installed %s in %ss": "npx: %s installé(s) en %ss",

i would keep "dans" instead of "en", but I agree for removing the "a" and adding a plural form.

@AntoineReneleau
Copy link
Contributor Author

@gorhgorh It was actually the first change I made (before reviewing the rest of the file).
I don't understand why you prefer "dans".
"dans" is "inside", a physical location, it's not correct for an elapsed time.

@gorhgorh
Copy link
Contributor

gorhgorh commented Jul 12, 2017

... you are totally right, I'm using a en/uk system and did not had this sentence in context. Your version is right @zkat this pr is ok to merge, and thank to @AntoineReneleau for catching this one.

@zkat zkat merged commit f277fc7 into zkat:latest Jul 12, 2017
@AntoineReneleau AntoineReneleau deleted the patch-1 branch July 13, 2017 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants