-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local Background file not loading. (Firefox) #69
Comments
For the record it only shows these errors when the CSS filter is enabled, it does not show these in the regular Error or Warning filters. Also, it is loading the local background for me. But not every image will load. I've tried different resolutions, file sizes, file types, and special characters in file names. For example these images work on my end: It might be the Filesize? Highest I was able to load was 665KB. Weird, because Firefox is not supposed to have a Local Storage limit. |
This is interesting, thanks @Munkenmo and @Q-out for the info and details. I've not got a windows machine to test on so this is difficult for me to address. I've got a VM sort of running and am looking into this. (for the record the background image is rendered as expected on MacOS Chrome and Firefox latest). Bear with me as I investigate. |
I think Q-out might be onto something with file size. I took my normal background picture, a 4.9MB .png, opened it, used paint.net to save it as a .jpg and lowered quality until it came down to 671KB, and the lower quality version is working. |
If I want to change the background color, how can I do that? |
@sinankizar nightTab is a stylised new tab page. Sorry, It does not have controls to freely change the main body background colour. This is to maintain the overall look and feel of the project and to keep colour contrast for text. And to make sure the light/dark theme system works as expected. That being said there are a few ways to make some background colour changes:
I hope that helps. |
Thanks for the fast reply. I have managed change the background color with the image that has the color of my choice. Other aspects such as dark theme works flawlessly. It is the best addon for firefox. Thanks for the efforts you put it in. |
@sinankizar Bah! I went ahead and added background colour options so if a user knows the risk, can make a custom colour change. It'll be pushed out to the extension/add on in a few days. |
You’re the man! When i set an image, the tab bar and the title bar sometimes expanding unexpectedly. If i can reproduce the issue, i will post the details. Thank you so much👍🏻 |
I have also some Images that don't show when I select them as background image. Other images from that folder work. Here are 3 examples that don't show up as background image when selected via the file dialog: The first one shows up when used via online source (https://i.imgur.com/VzhPD4e.png). The others I don't know. |
Thank you @anonymous133 for more details. I'm still investigating alternative ways to load local files. This issues is a tough one. |
After a lot of investigating and a few project changes, local images was dropped from the project scope. Closing this issue as I can't support this feature any more. |
OS : Windows 10
Firefox : Version 68.0.1
NightTab : 3.61.0 (Addon)
When selecting a local background file, no background appears. Using a URL works fine. (I've also exported my backup.json to chrome, and everything works fine there.)
Attached is a copy of the error log that appears in console:
This log was taken after clearing the addon data and closing / reopening firefox.
I then loaded a local background file, but the error log was the same, (even after closing / reopening)
Loading a URL background also resulted in the same errors, but does display a background.
The text was updated successfully, but these errors were encountered: