Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create API ML sample extension #1947

Merged
merged 33 commits into from
Jan 5, 2022
Merged

feat: Create API ML sample extension #1947

merged 33 commits into from
Jan 5, 2022

Conversation

taban03
Copy link
Contributor

@taban03 taban03 commented Dec 2, 2021 •
edited
Loading

Description

Sample extension for api ml to showcase how to create an extension for API ML (to be added in the GW class path as part of Zowe preparation).
The module contains a simple controller

Linked to #1067
Dependent on the zowe/zowe-install-packaging#2502 PR

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@taban03 taban03 marked this pull request as draft December 2, 2021 14:17
@taban03
Fix gradle creation of jar
ad68337 
Signed-off-by: at670475 <[email protected]>
@taban03
Add doc
6cfc9a1 
Signed-off-by: at670475 <[email protected]>
@taban03 taban03 marked this pull request as ready for review December 3, 2021 13:51
@taban03
Remove jib
1c86098 
Signed-off-by: at670475 <[email protected]>
@taban03 taban03 marked this pull request as draft December 3, 2021 14:03
@taban03
Clean up dependencies
38d00c6 
Signed-off-by: at670475 <[email protected]>
@taban03
skip sonar scan
1a2c321 
Signed-off-by: at670475 <[email protected]>
@taban03 taban03 marked this pull request as ready for review December 3, 2021 15:09
achmelo
achmelo reviewed Dec 6, 2021
View reviewed changes
Copy link
Member

@achmelo achmelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you know that this works?

balhar-jakub
balhar-jakub approved these changes Dec 6, 2021
View reviewed changes
apiml-sample-extension-package/src/main/resources/manifest.yaml Outdated Show resolved Hide resolved
apiml-sample-extension/README.md Outdated Show resolved Hide resolved
apiml-sample-extension/README.md Outdated Show resolved Hide resolved
apiml-sample-extension/build.gradle Outdated Show resolved Hide resolved
apiml-sample-extension/gradle/lite.gradle Outdated Show resolved Hide resolved
build.gradle Show resolved Hide resolved
gradle/sonar.gradle Show resolved Hide resolved
@taban03 taban03 added the do not merge Do not merge! label Dec 6, 2021
@taban03 taban03 force-pushed the apiml/GH1067/create_sample_ext branch from c7424f1 to 1cee23d Compare December 10, 2021 09:50
taban03 and others added 12 commits December 14, 2021 09:52
@taban03
Create and package sample extension
a2a8b0f 
Signed-off-by: at670475 <[email protected]>
@taban03
ADD the path to the jar
d1f173d 
Signed-off-by: at670475 <[email protected]>
@taban03
Fix gradle creation of jar
7c5aa82 
Signed-off-by: at670475 <[email protected]>
@taban03
Add doc
dd1c4fd 
Signed-off-by: at670475 <[email protected]>
@taban03
Remove jib
66078ce 
Signed-off-by: at670475 <[email protected]>
@taban03
Clean up dependencies
afb30b9 
Signed-off-by: at670475 <[email protected]>
@taban03
skip sonar scan
55d388f 
Signed-off-by: at670475 <[email protected]>
@achmelo @taban03
package controller and dependencies
daac43a 
Signed-off-by: achmelo <[email protected]>
@taban03
Address requests
dbc6d26 
Signed-off-by: at670475 <[email protected]>
@taban03
Update doc
97fd5a2 
Signed-off-by: at670475 <[email protected]>
@taban03
Replace back icon to use material
ca9c436 
Signed-off-by: at670475 <[email protected]>
@taban03
Revert change
e38557f 
Signed-off-by: at670475 <[email protected]>
@taban03 taban03 force-pushed the apiml/GH1067/create_sample_ext branch from 5418d65 to e38557f Compare December 14, 2021 08:52
taban03 and others added 10 commits December 14, 2021 09:59
@taban03
Fix action
2f88ab0 
Signed-off-by: at670475 <[email protected]>
@taban03
attempt
9523f0b 
Signed-off-by: at670475 <[email protected]>
@taban03
Attempt 2
52afe66 
Signed-off-by: at670475 <[email protected]>
@taban03
Attempt 3
d31c06d 
Signed-off-by: at670475 <[email protected]>
@taban03
Fix PR name
01b1a86 
Signed-off-by: at670475 <[email protected]>
@taban03
Fix extension path
e26aee1 
Signed-off-by: at670475 <[email protected]>
@taban03
Fix extension path
f2dff31 
Signed-off-by: at670475 <[email protected]>
@taban03
Fix extension path
7ccb86e 
Signed-off-by: at670475 <[email protected]>
@achmelo
Merge remote-tracking branch 'origin/apiml/GH1067/create_sample_ext' …
a2adda2 
…into apiml/GH1067/create_sample_ext

# Conflicts:
#	apiml-sample-extension-package/src/main/resources/manifest.yaml
#	apiml-sample-extension/README.md
#	apiml-sample-extension/build.gradle
#	gradle/license.gradle
#	gradle/sonar.gradle
@taban03
Change extension package to be included in the component scan
c2619b8 
Signed-off-by: at670475 <[email protected]>
@taban03 taban03 changed the title Create API ML sample extension feat: Create API ML sample extension Dec 17, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@taban03 taban03 removed the do not merge Do not merge! label Jan 5, 2022
@taban03 taban03 merged commit a085cf3 into master Jan 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the apiml/GH1067/create_sample_ext branch January 5, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achmelo achmelo achmelo left review comments

@balhar-jakub balhar-jakub balhar-jakub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taban03 @balhar-jakub @achmelo