Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include extensions in to the Discovery Service classpath and include support of extensions with native libraries #1968

Closed
arxioly opened this issue Dec 14, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@arxioly
Copy link
Contributor

arxioly commented Dec 14, 2021

Is your feature request related to a problem? Please describe.
A new "standard" way to enable extensions in APIML supports only including extension in to the API Gateway classpath. But we have APIML extension (Audit Log), which extends also Discovery Service, so it also needs to be added to the Discovery Service classpath.

Also we are working on a new extension which requires including native libraries to the java.library.path, and we would like to have a standard way to include our libraries to the LIBPATH. I'm not sure that we can use LIBRARY_PATH variable for that purpose.

Describe the solution you'd like

  1. Create a similar to API Gateway environment variable, like ZWE_DISCOVERY_SHARED_LIBS which will include extensions to the Discovery Service classpath in start.sh. For example:
...
if [[ ! -z ${ZWE_DISCOVERY_SHARED_LIBS} ]]
then
    DISCOVERY_LOADER_PATH=${ZWE_DISCOVERY_SHARED_LIBS},${DISCOVERY_LOADER_PATH}
fi
...
-Dloader.path=${DISCOVERY_LOADER_PATH} \
  1. Create new environment variable, like ZWE_GATEWAY_LIBRARY_PATH to include Extension's native libraries to the LIBPATH of the API Gateway. For example:
...
LIBPATH="$LIBPATH":"${LIBRARY_PATH}"
if [[ ! -z ${ZWE_GATEWAY_LIBRARY_PATH} ]]
then
    LIBPATH="$LIBPATH":"${ZWE_GATEWAY_LIBRARY_PATH}"
fi
...

Most important that both environment variables could be set in instance.env.

Describe alternatives you've considered
LPL team can create PR with these changes.

@arxioly arxioly added enhancement New feature or request new New issue that has not been worked on yet labels Dec 14, 2021
@achmelo achmelo added 21PI4 and removed new New issue that has not been worked on yet labels Jan 5, 2022
@CarsonCook CarsonCook self-assigned this Jan 10, 2022
@CarsonCook
Copy link
Contributor

PR to add the requested changes: #1987
PR to docs site: zowe/docs-site#1959
@arxioly please let me know if you have any comments, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants