Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: UI pass change #2035

Merged
merged 18 commits into from
Jan 26, 2022
Merged

feat: UI pass change #2035

merged 18 commits into from
Jan 26, 2022

Conversation

achmelo
Copy link
Member

@achmelo achmelo commented Jan 25, 2022

Description

Support password change via API Catalog UI

Linked to #1852

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

achmelo added 14 commits January 21, 2022 10:10
@achmelo
password change prepare
9ec9958 
Signed-off-by: achmelo <[email protected]>
@achmelo
validate new password, return to login,
3da6332 
Signed-off-by: achmelo <[email protected]>
@achmelo
keep expiredPass window
270622c 
Signed-off-by: achmelo <[email protected]>
@achmelo
field level warning
8ef8741 
Signed-off-by: achmelo <[email protected]>
@achmelo
suspended account info
3afc631 
Signed-off-by: achmelo <[email protected]>
@achmelo
refactor
59b3649 
Signed-off-by: achmelo <[email protected]>
@achmelo
align error numbers
04988f4 
Signed-off-by: achmelo <[email protected]>
@achmelo
working v2 transfer
a43bb70 
Signed-off-by: achmelo <[email protected]>
@achmelo
button styles
4cc6ba1 
Signed-off-by: achmelo <[email protected]>
@achmelo
v2 layout of login page
927a262 
Signed-off-by: achmelo <[email protected]>
@achmelo
add new bcg image
0d5da12 
Signed-off-by: achmelo <[email protected]>
@achmelo
css tweaks
57d8be7 
Signed-off-by: achmelo <[email protected]>
@achmelo
Merge remote-tracking branch 'origin/v2.x.x' into rip/GH1852/v2_ui_pa…
14e2dd5 
…ss_change

# Conflicts:
#	api-catalog-ui/frontend/package-lock.json
#	api-catalog-ui/frontend/src/actions/user-actions.jsx
#	api-catalog-ui/frontend/src/components/Login/Login.jsx
#	api-catalog-ui/frontend/src/reducers/authentication-reducer.test.jsx
@achmelo
lint fixes
357c04f 
Signed-off-by: achmelo <[email protected]>
@zowe-robot zowe-robot added the Sensitive Sensitive change that requires peer review label Jan 25, 2022
@achmelo
do not allow debugger
6a64d38 
Signed-off-by: achmelo <[email protected]>
@achmelo achmelo changed the title Rip/gh1852/v2 UI pass change feat: UI pass change Jan 25, 2022
taban03
taban03 approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@taban03 taban03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thanks Andrej.

@achmelo
GW login interface update
4a4ca2e 
Signed-off-by: achmelo <[email protected]>
@achmelo
code coverage
e832393 
Signed-off-by: achmelo <[email protected]>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 2 Code Smells

78.0% 78.0% Coverage
0.3% 0.3% Duplication

@achmelo achmelo merged commit 139a231 into v2.x.x Jan 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the rip/GH1852/v2_ui_pass_change branch January 26, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taban03 taban03 taban03 approved these changes

Assignees
No one assigned
Labels
Sensitive Sensitive change that requires peer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achmelo @taban03 @zowe-robot