fix: Add server side logging for swagger handling code #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carson Cook <[email protected]>
…swagger-server-side-logging
Signed-off-by: Carson Cook <[email protected]>
Signed-off-by: Carson Cook <[email protected]>
Signed-off-by: Carson Cook <[email protected]>
|
Code coverage is low, but this was just adding logging statements (with one exception message updated and covered in unit tests). |
|
SonarCloud Quality Gate failed. |
achmelo
approved these changes
Apr 28, 2022
delete-merged-branch
bot
deleted the
apiml/GH2315/swagger-server-side-logging
branch
CarsonCook
added a commit
that referenced
this pull request
Apr 29, 2022
* fix: add proper server side logging for swagger handling Signed-off-by: Carson Cook <[email protected]> * Misc grammar improvements Signed-off-by: Carson Cook <[email protected]> * Fix unit test Signed-off-by: Carson Cook <[email protected]> * Organize unit tests Signed-off-by: Carson Cook <[email protected]>
CarsonCook
added a commit
that referenced
this pull request
Apr 29, 2022
* fix: documentation for apidoc endpoints (#2326) * Fix documentation for diff endpoint Signed-off-by: Carson Cook <[email protected]> * Fix doc for getApiDoc endpoint: Signed-off-by: Carson Cook <[email protected]> * Fix integration test Signed-off-by: Carson Cook <[email protected]> * feat: Create endpoint to retrieve default API doc for service (#2327) * Add unit tests for api doc controller Signed-off-by: Carson Cook <[email protected]> * Add default api doc endpoint Signed-off-by: Carson Cook <[email protected]> * Add integration test for default api doc endpoint Signed-off-by: Carson Cook <[email protected]> * Return 404 when api doc not found Signed-off-by: Carson Cook <[email protected]> * Fix integration test for default apidoc Signed-off-by: Carson Cook <[email protected]> * Fix typo Signed-off-by: Carson Cook <[email protected]> * Fix imports Signed-off-by: Carson Cook <[email protected]> * Fix apidoc path for auth tests Signed-off-by: Carson Cook <[email protected]> * Fix unit test Signed-off-by: Carson Cook <[email protected]> * Fix api catalog auth integration tests Signed-off-by: Carson Cook <[email protected]> * fix: Add server side logging for swagger handling code (#2328) * fix: add proper server side logging for swagger handling Signed-off-by: Carson Cook <[email protected]> * Misc grammar improvements Signed-off-by: Carson Cook <[email protected]> * Fix unit test Signed-off-by: Carson Cook <[email protected]> * Organize unit tests Signed-off-by: Carson Cook <[email protected]> * fix: verify ssl certs takes precedence over nonstrict verify (#2330) Signed-off-by: Carson Cook <[email protected]> * fix: Normalize swagger paths (#2331) * Normalize swagger paths Signed-off-by: Carson Cook <[email protected]> * Add unit tests Signed-off-by: Carson Cook <[email protected]> * Fix imports Signed-off-by: Carson Cook <[email protected]> * Only normalize double slash Signed-off-by: Carson Cook <[email protected]> * Fix stylign Signed-off-by: Carson Cook <[email protected]> * Fix sonar smell Signed-off-by: Carson Cook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add better logging for server side code in API Catalog that handles swagger, errors and warnings are logged and more debug information is logged. This will greatly help with debugging why a swagger document isn't rendered in the Catalog.
Linked to #2315
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline