Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: accept PAT for SSO #2499

Merged
merged 13 commits into from
Jul 20, 2022
Merged

feat: accept PAT for SSO #2499

merged 13 commits into from
Jul 20, 2022

Conversation

achmelo
Copy link
Member

@achmelo achmelo commented Jul 14, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Linked to #2469
Part of the #2257

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

achmelo added 2 commits July 13, 2022 18:18
@achmelo
include PAT in SSO
7cc6281 
Signed-off-by: achmelo <[email protected]>
@achmelo
PAT ITs
b998d55 
Signed-off-by: achmelo <[email protected]>
@zowe-robot zowe-robot added the Sensitive Sensitive change that requires peer review label Jul 14, 2022
@achmelo achmelo closed this Jul 15, 2022
@achmelo achmelo reopened this Jul 18, 2022
@achmelo achmelo marked this pull request as ready for review July 19, 2022 14:31
taban03
taban03 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@taban03 taban03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a code smell to be fixed. Beside that, it looks good to me.

weinfurt
weinfurt approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@weinfurt weinfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.7% 88.7% Coverage
0.0% 0.0% Duplication

@achmelo achmelo merged commit ad17c18 into v2.x.x Jul 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the rip/gh2469/pat_sso branch July 20, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taban03 taban03 taban03 approved these changes

@weinfurt weinfurt weinfurt approved these changes

Assignees
No one assigned
Labels
Sensitive Sensitive change that requires peer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achmelo @weinfurt @taban03 @zowe-robot