Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add customized code snippets to API Catalog #2526

Merged
merged 11 commits into from
Aug 10, 2022
Merged

feat: Add customized code snippets to API Catalog #2526

merged 11 commits into from
Aug 10, 2022

Conversation

taban03
Copy link
Contributor

@taban03 taban03 commented Jul 26, 2022 •
edited
Loading

Signed-off-by: at670475 [email protected]

Description

Add customised code snippets to the API Catalog UI. The hand-crafted snippets can now be defined as part of the service metadata and will be displayed in the API Catalog UI.
Linked to #2385
Part of the #2208

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

achmelo added 2 commits August 9, 2022 14:43
@achmelo
snippets fix
e17f02c 
Signed-off-by: achmelo <[email protected]>
@achmelo
remove log
dc7ef72 
Signed-off-by: achmelo <[email protected]>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.4% 70.4% Coverage
0.0% 0.0% Duplication

@taban03 taban03 merged commit 602392e into v2.x.x Aug 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the apiml/GH2385/new_customized_snippets branch August 10, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarsonCook CarsonCook CarsonCook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taban03 @CarsonCook @achmelo