Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade swagger parser and exclude bugged version #2702

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

taban03
Copy link
Contributor

@taban03 taban03 commented Dec 6, 2022

Signed-off-by: at670475 [email protected]

Description

Upgrade swagger-parser-v3 to fix bug with anyOf and allOf props not being parsed.

Fixes #2676

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@taban03 taban03 changed the title Fix: Upgrade swagger parser and exclude bugged version fix: Upgrade swagger parser and exclude bugged version Dec 6, 2022
@taban03 taban03 closed this Dec 6, 2022
Signed-off-by: at670475 <[email protected]>
@taban03 taban03 reopened this Dec 6, 2022
@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 6, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability D 1 Vulnerability
Security Hotspot E 2 Security Hotspots
Code Smell A 13 Code Smells

86.0% 86.0% Coverage
0.7% 0.7% Duplication

@taban03 taban03 merged commit 6b966b2 into v2.x.x Dec 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the apiml/GH2676/update_swagger_parser branch December 7, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error rendering swagger with allOf and anyOf logic in schema
2 participants