Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mitigate storing password in the memory #2867

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

pj892031
Copy link
Contributor

Description

In Java is a known issue that passwords stored as String are not under control. It can be minimized by using char arrays instead of String. It will not completely solve the issue, just reduce it a little bit. This PR changes the password stored as a string into an array of chars where possible.

This PR adds a part explored during the implementation of #2862.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: Pavel Jareš <[email protected]>
@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Apr 14, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@pj892031 pj892031 marked this pull request as ready for review April 14, 2023 13:50
@pj892031 pj892031 merged commit 3356b7c into v2.x.x Apr 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the reboot/mitigateStoredPasswords branch April 14, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sensitive Sensitive change that requires peer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants