Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cloud Gateway - create additional registrations #3181

Merged
merged 10 commits into from
Nov 6, 2023

Conversation

cumarav
Copy link
Contributor

@cumarav cumarav commented Oct 31, 2023

Description

Implement support for additional Eureka Clients apiml.service.additionalRegistration in CloudGateway application

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@cumarav cumarav force-pushed the reboot/cloudGatewayAdditionalRegistrations branch from 083551d to 44cf440 Compare October 31, 2023 16:19
@pull-request-size pull-request-size bot added size/M and removed size/L labels Oct 31, 2023
@cumarav cumarav force-pushed the reboot/cloudGatewayAdditionalRegistrations branch from 44cf440 to 0a3dbd4 Compare November 1, 2023 08:58
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 1, 2023
@cumarav cumarav force-pushed the reboot/cloudGatewayAdditionalRegistrations branch 5 times, most recently from 54cf5d9 to 1e6a5a3 Compare November 2, 2023 15:45
@cumarav cumarav force-pushed the reboot/cloudGatewayAdditionalRegistrations branch from 1e6a5a3 to 18c2296 Compare November 3, 2023 07:33
@cumarav cumarav marked this pull request as ready for review November 3, 2023 08:04
Copy link
Contributor Author

@cumarav cumarav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed issues which I agreed with, others are commented.

@cumarav cumarav force-pushed the reboot/cloudGatewayAdditionalRegistrations branch from 2dabf41 to 650b162 Compare November 6, 2023 10:00
@cumarav cumarav force-pushed the reboot/cloudGatewayAdditionalRegistrations branch from 650b162 to 281cdf2 Compare November 6, 2023 10:24
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.4% 91.4% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@pj892031 pj892031 merged commit c6cc561 into v2.x.x Nov 6, 2023
31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/cloudGatewayAdditionalRegistrations branch November 6, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants