Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update bean definitions for noop cache mode #3197

Merged
merged 3 commits into from
Nov 14, 2023
Merged

fix: update bean definitions for noop cache mode #3197

merged 3 commits into from
Nov 14, 2023

Conversation

pablocarle
Copy link
Contributor

Description

Cache in NoOp mode should not be used in production. It was failing due to logic validating the correct type of cache implementation.

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

taban03
taban03 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@taban03 taban03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

add missing beans in noop mode
3df700e 
Signed-off-by: Pablo Hernán Carle <[email protected]>
@pablocarle pablocarle marked this pull request as ready for review November 13, 2023 15:42
@pablocarle pablocarle requested a review from pj892031 November 13, 2023 15:42
add test for noop
1736f33 
Signed-off-by: Pablo Hernán Carle <[email protected]>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 13, 2023
pj892031
pj892031 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@pj892031 pj892031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just please update the title of PR with a proper prefix.

@pablocarle pablocarle changed the title Update bean definitions for noop cache mode fix: update bean definitions for noop cache mode Nov 14, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@pablocarle pablocarle merged commit b73d812 into v2.x.x Nov 14, 2023
32 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/fix/noop-cache branch November 14, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pj892031 pj892031 pj892031 approved these changes

@taban03 taban03 taban03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablocarle @taban03 @pj892031