fix: Fix of resource leak in loading of images in API Catalog #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taban03
approved these changes
Dec 8, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
pj892031
added a commit
that referenced
this pull request
Dec 18, 2023
Signed-off-by: Pavel Jares <[email protected]>
balhar-jakub
added a commit
that referenced
this pull request
Dec 18, 2023
* Update changelog Signed-off-by: Zowe Robot <[email protected]> Signed-off-by: Pavel Jares <[email protected]> * fix content of the new changelog Signed-off-by: Pavel Jares <[email protected]> * change logs enhancements Signed-off-by: Pavel Jares <[email protected]> * [skip ci] Update version Signed-off-by: Pavel Jares <[email protected]> * [Gradle Release plugin] [skip ci] Before tag commit 'v2.13.1'. Signed-off-by: Pavel Jares <[email protected]> * [Gradle Release plugin] Create new version: 'v2.13.2-SNAPSHOT'. Signed-off-by: Pavel Jares <[email protected]> * feat: ZAAS /safIdt endpoint to generate SAF ID token for authenticated user (#3220) * New ZAAS safIdt endpoint to generate SAF ID tokens for authenticated user. Signed-off-by: Petr Weinfurt <[email protected]> * IT tests for safIdt endpoint. Signed-off-by: Petr Weinfurt <[email protected]> * Address code review comments. Signed-off-by: Petr Weinfurt <[email protected]> * Remove unused class Signed-off-by: Petr Weinfurt <[email protected]> * Fix tests Signed-off-by: Petr Weinfurt <[email protected]> * Fix IT tests Signed-off-by: Petr Weinfurt <[email protected]> * Fix unit tests Signed-off-by: Petr Weinfurt <[email protected]> * Add Controller Advice to handle exceptions. Signed-off-by: Petr Weinfurt <[email protected]> * Handle more exceptions. Signed-off-by: Petr Weinfurt <[email protected]> * Add content type and body to negative test. Signed-off-by: Petr Weinfurt <[email protected]> * Add content type and body to negative test. Signed-off-by: Petr Weinfurt <[email protected]> * Add content type and body to negative test. Signed-off-by: Petr Weinfurt <[email protected]> * Add negative tests with valid Okta token and no mapping. Signed-off-by: Petr Weinfurt <[email protected]> * Fix Rest assured RequestSpec preparation. Signed-off-by: Petr Weinfurt <[email protected]> * Checkout the main branch before Sonar scan to resolve issue 'Could not find ref 'v2.x.x' in refs/heads, refs/remotes/upstream or refs/remotes/origin.' Signed-off-by: Petr Weinfurt <[email protected]> * Fetch the main branch before Sonar scan to resolve issue 'Could not find ref 'v2.x.x' in refs/heads, refs/remotes/upstream or refs/remotes/origin.' Signed-off-by: Petr Weinfurt <[email protected]> * Replace deprecated sonar.login property Signed-off-by: Petr Weinfurt <[email protected]> * Fetch depth 0 Signed-off-by: Petr Weinfurt <[email protected]> * Handle TokenNotValid and TokenExpired exception with 401 response. Signed-off-by: Petr Weinfurt <[email protected]> --------- Signed-off-by: Petr Weinfurt <[email protected]> Signed-off-by: Pavel Jares <[email protected]> * Update CONTRIBUTING.md (#3206) Add step-by-step instructions for contributing Remove irelevant parts of the Retrospective Signed-off-by: Jakub Balhar <[email protected]> Signed-off-by: Pavel Jares <[email protected]> * fix: Fix of resource leak in loading of images in API Catalog (#3233) Signed-off-by: Pavel Jares <[email protected]> * chore: Upgrade of LogBack and Spring Boot (#3232) Signed-off-by: Pavel Jares <[email protected]> * update changelog Signed-off-by: Pavel Jares <[email protected]> * feat: Cloud Gateway SAF IDT auth scheme (#3234) * chore: move babel to dev, modify webpack config, spring security Signed-off-by: achmelo <[email protected]> * read keys from common httpsconfig Signed-off-by: achmelo <[email protected]> * New ZAAS safIdt endpoint to generate SAF ID tokens for authenticated user. Signed-off-by: Petr Weinfurt <[email protected]> * IT tests for safIdt endpoint. Signed-off-by: Petr Weinfurt <[email protected]> * initial safidt filter impl Signed-off-by: achmelo <[email protected]> * Address code review comments. Signed-off-by: Petr Weinfurt <[email protected]> * Remove unused class Signed-off-by: Petr Weinfurt <[email protected]> * Fix tests Signed-off-by: Petr Weinfurt <[email protected]> * Fix IT tests Signed-off-by: Petr Weinfurt <[email protected]> * Fix unit tests Signed-off-by: Petr Weinfurt <[email protected]> * Add Controller Advice to handle exceptions. Signed-off-by: Petr Weinfurt <[email protected]> * refactor, unit tests Signed-off-by: achmelo <[email protected]> * Handle more exceptions. Signed-off-by: Petr Weinfurt <[email protected]> * safidt service in test Signed-off-by: achmelo <[email protected]> * Add content type and body to negative test. Signed-off-by: Petr Weinfurt <[email protected]> * Add content type and body to negative test. Signed-off-by: Petr Weinfurt <[email protected]> * Add content type and body to negative test. Signed-off-by: Petr Weinfurt <[email protected]> * Add negative tests with valid Okta token and no mapping. Signed-off-by: Petr Weinfurt <[email protected]> * Fix Rest assured RequestSpec preparation. Signed-off-by: Petr Weinfurt <[email protected]> * Checkout the main branch before Sonar scan to resolve issue 'Could not find ref 'v2.x.x' in refs/heads, refs/remotes/upstream or refs/remotes/origin.' Signed-off-by: Petr Weinfurt <[email protected]> * Fetch the main branch before Sonar scan to resolve issue 'Could not find ref 'v2.x.x' in refs/heads, refs/remotes/upstream or refs/remotes/origin.' Signed-off-by: Petr Weinfurt <[email protected]> * Replace deprecated sonar.login property Signed-off-by: Petr Weinfurt <[email protected]> * Replace deprecated sonar.login property Signed-off-by: Petr Weinfurt <[email protected]> * remove git fetch Signed-off-by: Petr Weinfurt <[email protected]> * Fetch depth 0 Signed-off-by: Petr Weinfurt <[email protected]> * Fetch depth 0 Signed-off-by: Petr Weinfurt <[email protected]> * Add SAF IDT request to negative IT tests Signed-off-by: Petr Weinfurt <[email protected]> * Handle TokenNotValid and TokenExpired exception with 401 response. Signed-off-by: Petr Weinfurt <[email protected]> * Handle TokenNotValid and TokenExpired exception with 401 response. Signed-off-by: Petr Weinfurt <[email protected]> * remove duplicated code Signed-off-by: achmelo <[email protected]> * delete unused imports Signed-off-by: achmelo <[email protected]> --------- Signed-off-by: achmelo <[email protected]> Signed-off-by: Petr Weinfurt <[email protected]> Co-authored-by: Petr Weinfurt <[email protected]> Signed-off-by: Pavel Jares <[email protected]> * [skip ci] Update version Signed-off-by: Pavel Jares <[email protected]> * [Gradle Release plugin] [skip ci] Before tag commit 'v2.13.2'. Signed-off-by: Pavel Jares <[email protected]> * [Gradle Release plugin] Create new version: 'v2.13.3-SNAPSHOT'. Signed-off-by: Pavel Jares <[email protected]> * chore: support additional contents - catalog (#3215) * add content mapping - wip Signed-off-by: at670475 <[email protected]> * fix slint Signed-off-by: at670475 <[email protected]> * embed medium blogs Signed-off-by: at670475 <[email protected]> * remove config Signed-off-by: at670475 <[email protected]> * fix Signed-off-by: at670475 <[email protected]> * add expandable icons Signed-off-by: at670475 <[email protected]> * wip - use cases work Signed-off-by: at670475 <[email protected]> * format cases Signed-off-by: at670475 <[email protected]> * fix Signed-off-by: at670475 <[email protected]> * open new tab for links Signed-off-by: at670475 <[email protected]> * embed internal doc Signed-off-by: at670475 <[email protected]> * adjusting based on the design decision Signed-off-by: at670475 <[email protected]> * fix css Signed-off-by: at670475 <[email protected]> * fix Signed-off-by: at670475 <[email protected]> * fix Signed-off-by: at670475 <[email protected]> * fix window size Signed-off-by: at670475 <[email protected]> * fix css Signed-off-by: at670475 <[email protected]> * fix Signed-off-by: at670475 <[email protected]> * fix margin between videos Signed-off-by: at670475 <[email protected]> * revert back Signed-off-by: at670475 <[email protected]> * fix label name Signed-off-by: at670475 <[email protected]> * add check for title and description Signed-off-by: at670475 <[email protected]> * disable link Signed-off-by: at670475 <[email protected]> * add tests Signed-off-by: at670475 <[email protected]> * fix Signed-off-by: at670475 <[email protected]> * clean up of codea nd tests Signed-off-by: at670475 <[email protected]> * clean up Signed-off-by: at670475 <[email protected]> * increase default counter Signed-off-by: at670475 <[email protected]> * revert back tests Signed-off-by: at670475 <[email protected]> * add margin to blogs Signed-off-by: at670475 <[email protected]> * fix button Signed-off-by: at670475 <[email protected]> * support zowe doc tutorials Signed-off-by: at670475 <[email protected]> * fix testa Signed-off-by: at670475 <[email protected]> * fix test Signed-off-by: at670475 <[email protected]> * increase coverage Signed-off-by: at670475 <[email protected]> * reduce complexity Signed-off-by: at670475 <[email protected]> * fix code smells Signed-off-by: at670475 <[email protected]> * fix Signed-off-by: at670475 <[email protected]> * fix code smells Signed-off-by: at670475 <[email protected]> * fix code smell Signed-off-by: at670475 <[email protected]> * fix bug Signed-off-by: at670475 <[email protected]> * add tests Signed-off-by: at670475 <[email protected]> * fix bug Signed-off-by: at670475 <[email protected]> * add test Signed-off-by: at670475 <[email protected]> * fix test Signed-off-by: at670475 <[email protected]> * refactoring Signed-off-by: at670475 <[email protected]> * fix test Signed-off-by: at670475 <[email protected]> * fix Signed-off-by: at670475 <[email protected]> * optymize Signed-off-by: at670475 <[email protected]> * fix Signed-off-by: at670475 <[email protected]> * add tests Signed-off-by: at670475 <[email protected]> * fix test Signed-off-by: at670475 <[email protected]> * add test Signed-off-by: at670475 <[email protected]> * add tests Signed-off-by: at670475 <[email protected]> * fix Signed-off-by: at670475 <[email protected]> * fix issue with description Signed-off-by: at670475 <[email protected]> * add test Signed-off-by: at670475 <[email protected]> * add test Signed-off-by: at670475 <[email protected]> --------- Signed-off-by: at670475 <[email protected]> Signed-off-by: Pavel Jares <[email protected]> * chore: AT-TLS context configuration tests (#3236) --------- Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Signed-off-by: Pavel Jares <[email protected]> * [skip ci] Update version Signed-off-by: Pavel Jares <[email protected]> * [Gradle Release plugin] [skip ci] Before tag commit 'v2.13.3'. Signed-off-by: Pavel Jares <[email protected]> * [Gradle Release plugin] Create new version: 'v2.13.4-SNAPSHOT'. Signed-off-by: Pavel Jares <[email protected]> * DCO commit Signed-off-by: Pavel Jares <[email protected]> --------- Signed-off-by: Zowe Robot <[email protected]> Signed-off-by: Pavel Jares <[email protected]> Signed-off-by: Petr Weinfurt <[email protected]> Signed-off-by: Jakub Balhar <[email protected]> Signed-off-by: achmelo <[email protected]> Signed-off-by: at670475 <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Zowe Robot <[email protected]> Co-authored-by: Pavel Jareš <[email protected]> Co-authored-by: Petr Weinfurt <[email protected]> Co-authored-by: Jakub Balhar <[email protected]> Co-authored-by: Pavel Jareš <[email protected]> Co-authored-by: achmelo <[email protected]> Co-authored-by: Andrea Tabone <[email protected]> Co-authored-by: Pablo Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The input stream responsible for loading images was not correctly close. It is a potential resource leak.
Linked to # (issue)
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline