Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix disabling EhCache #3280

Merged
merged 2 commits into from
Jan 24, 2024
Merged

fix: Fix disabling EhCache #3280

merged 2 commits into from
Jan 24, 2024

Conversation

pj892031
Copy link
Contributor

Description

This PR is a fix to be able to start GW with the argument apiml.caching.enabled=false . The previous PR (#3276) contains a wrong bean name.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@pj892031 pj892031 marked this pull request as ready for review January 23, 2024 14:14
@pj892031 pj892031 requested a review from achmelo January 23, 2024 14:14
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pj892031 pj892031 merged commit a3067b9 into v2.x.x Jan 24, 2024
31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/fix-disabling-eh-cache branch January 24, 2024 15:18
pj892031 added a commit that referenced this pull request Jan 24, 2024
pj892031 added a commit that referenced this pull request Jan 25, 2024
… 2024-01-24 (#3289)

* support all type of blogs for both use cases and tutorials (#3275)

Signed-off-by: at670475 <[email protected]>

* chore: Sonar scanner runs with Java 17 (#3288)

* Separate coverage and sonar tasks.

Signed-off-by: Petr Weinfurt <[email protected]>

* Use variable for architecture

Signed-off-by: Petr Weinfurt <[email protected]>

* Use variable for architecture

Signed-off-by: Petr Weinfurt <[email protected]>

* Refine messages

Signed-off-by: Petr Weinfurt <[email protected]>

* Increase timeout

Signed-off-by: Petr Weinfurt <[email protected]>

---------

Signed-off-by: Petr Weinfurt <[email protected]>

* fix: Fix disabling EhCache (#3280)

---------

Signed-off-by: at670475 <[email protected]>
Signed-off-by: Petr Weinfurt <[email protected]>
Co-authored-by: Andrea Tabone <[email protected]>
Co-authored-by: Petr Weinfurt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants