Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Provide the correct external URL in the ZUUL Gateway if AT-TLS is enabled #3565

Merged
merged 3 commits into from
May 27, 2024

Conversation

pj892031
Copy link
Contributor

Description

In the case there is enabled AT-TLS for the ZUUL Gateway, it provides the external URL with HTTP protocol, which is wrong one. This fix change the schema to https instead.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: Pavel Jares <[email protected]>
@pj892031 pj892031 requested a review from achmelo May 27, 2024 10:39
@achmelo achmelo marked this pull request as ready for review May 27, 2024 10:39
pj892031 and others added 2 commits May 27, 2024 15:52
Signed-off-by: Pavel Jares <[email protected]>
* fix: allow key exchange port configuration (#3453)

* allow key exchange port configuration

Signed-off-by: achmelo <[email protected]>

* explain different defaults for the port

Signed-off-by: achmelo <[email protected]>

* use the same default port number

Signed-off-by: achmelo <[email protected]>

---------

Signed-off-by: achmelo <[email protected]>
(cherry picked from commit d82322e)

* configure external protocol from zowe yaml

Signed-off-by: achmelo <[email protected]>

---------

Signed-off-by: achmelo <[email protected]>
Copy link

@pj892031 pj892031 merged commit ef78150 into v2.x.x May 27, 2024
31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/external-url-attls-fix branch May 27, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants