Pull from Mainframe is adding extra characters to each record/line

[zFernand0]

When I right click on the member name and click "Pull from mainframe" it adds 1 space in front of each line of the JCL. So I delete that line, save the member and try to re-run the job and it still gives me this same error. I am not sure what is causing this reformat to happen, but it basically makes the option to use zowe through vs code unusable...

Originally posted by @LukeG-96 in #1116 (comment)

[github-actions]

Thank you for creating a bug report. If you haven't already, please ensure you have provided steps to reproduce it and as much context as possible.

[zFernand0]

Personally, I thought this could be related to a race condition in how we save and upload contents to the mainframe

• Details: Fix data corruption issues and document file save flow #2164
• Steps suggested: Submit start with a slash #1116 (comment)

---

From @LukeG-96:

I get the "Data Set Uploaded successfully" message but when I follow the steps you suggested it still puts one space in front of every line and adds a new line at the bottom...

Below is what is looks like after I make my changes and save the member:

Here is what it looks like after I issue a Pull from mainframe

[zFernand0]

Hey @LukeG-96 ,
Could you share the attributes of the dataset?
I tried a few things and I still cannot reproduce the Pull from mainframe adding an extra space.

List of things I tried:

• Data-loss issue in previous versions of Zowe Explorer (v2.6.2 and earlier)
  • With this mechanism I was able to reproduce the fact that my "edits" (i.e. removing all spaces at the front of each line) were not successfully uploaded, even though VSCode said otherwise.
  • Because of this, I was getting the spaces back after every Pull from Mainframe
  • Note: this was resolved in 2.7.0 (and I couldn't reproduce it the same way)
• CR/LF differences
  • I tried uploading content with different line-endings and pull from mainframe would just convert the line endings automatically (depending on the OS - Windows: CRLF | *nix - LF)
  • Result: no spaces being added to each line
• Record datasets
  • I tried downloading and uploading datasets and the only way to get it to fail was uploading a record-type dataset in binary format (to a PDS with variable record format)
  • This failure was expected since the first couple of bytes basically describe the the record length and it is not valid JCL
    
• Encoding differences
  • Results: Similar to the CR/LF, no spaces being added to each line
  • In this case, z/OS takes care of the conversion and the data/JCL should be fine as long as we don't change to a codepage that is fundamentally different.

[LukeG-96]

@zFernand0 As it turns out, my site is in the process of upgrading Endevor for our z/OS system. I believe this is the reason for my weird errors I'm receiving in VSCode for the Zowe extension.

Once we get this upgraded I am going to give this another try and see if it will work then.

I appreciate all your help on this and taking the time to open a new thread. I will post an update once we're upgraded and I've tested again.

[FALLAI-Denis]

Hi,

Similarly, pulling a file or a member from the mainframe adds a blank line to the end of the downloaded file, i.e. adds a newline after the last line which creates a blank line.

[zFernand0]

Similarly, pulling a file or a member from the mainframe adds a blank line to the end of the downloaded file, i.e. adds a newline after the last line which creates a blank line.

Hey @JillieBeanSim, should we create an issue for this particular behavior?

[JillieBeanSim]

@zFernand0 I would assume it would be handled along with this issue since newline = newline char at end of line