Proposed fix for issue #59 #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpl-zak
requested changes
Jan 6, 2025
| address->sin6_scope_id = sin.sin6_scope_id; | ||
| if (sin.sin6_family == AF_INET || (sin.sin6_family == AF_UNSPEC && sin.sin6_len == sizeof(struct sockaddr_in))) |
There was a problem hiding this comment.
The linux worker has failed to compile the code since sin does not have sin6_len defined. (afaik the field is only present if SIN6_LEN is defined)
Some adjustments have to be made to account for this difference on Linux platforms, whilst keeping the logic intact.
https://github.com/zpl-c/enet/actions/runs/12627791563/job/35194617740?pr=60#step:4:9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm trying to figure out what is the address family of the source socket upon receiving the message from it and if it is a ipv4 socket I convert it to the ipv6 on the fly.