Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users are able to type invalid values on textboxes #4

Closed
BrianLima opened this issue Oct 19, 2017 · 1 comment
Closed

Users are able to type invalid values on textboxes #4

BrianLima opened this issue Oct 19, 2017 · 1 comment

Comments

@BrianLima
Copy link

Users can type non hexadecimal values on the color hex code or type letters freely on R, G or B textboxes.

@zubetto
Copy link
Owner

zubetto commented Oct 20, 2017

Incorrect input is filtered out by the InputComponent and the ColorCodeParser methods.
I tried both your handlers and they still need the above filters because user can input exceeded value or paste arbitrary text from a clipboard. TextBoxPreviewTextInput allows to input digits only but it does not check if the input value exceeds 255. ColorCode_PreviewTextInput does not seem to work properly, I can type arbitrary characters.
It would be nice to verify user input by few lines of code, though!

@zubetto zubetto closed this as completed Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants