Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For emoji autocomplete, match insensitively to diacritics #1067

Open
gnprice opened this issue Nov 21, 2024 · 2 comments
Open

For emoji autocomplete, match insensitively to diacritics #1067

gnprice opened this issue Nov 21, 2024 · 2 comments
Labels
a-compose Compose box, autocomplete, attaching files/images a-i18n Translation, localization, internationalization
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Nov 21, 2024

For emoji autocomplete, if the emoji's name has é where the user's query has e or vice versa, we should treat that as a match. The semantics should match what the web app does.

This doesn't much arise for Unicode emoji, because for all the (small number of) Unicode emoji where a name has a diacritic, we also give the emoji an alternate name by removing the diacritics. It might come up for custom emoji in some realms.

Related issues

@gnprice gnprice added a-i18n Translation, localization, internationalization a-compose Compose box, autocomplete, attaching files/images labels Nov 21, 2024
@gnprice gnprice added this to the Post-launch milestone Nov 21, 2024
@gnprice
Copy link
Member Author

gnprice commented Nov 21, 2024

As part of the same work, let's also handle the possibility that the emoji's name has an upper-case letter where the query has lower case.

This one doesn't come up at all for Unicode emoji: all our names are in lower case. But again it might come up for custom emoji in some realms.

@chrisbobbe
Copy link
Collaborator

When making the search "fuzzy" like this, ideally we'd prioritize non-fuzzy matches over fuzzy matches. (zulip/zulip#32634 gave me the idea to comment here; we can split this to a new issue if helpful.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images a-i18n Translation, localization, internationalization
Projects
Status: No status
Development

No branches or pull requests

2 participants