Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msglist: Scroll-to-bottom button on message list #218

Closed
sirpengi opened this issue Jul 17, 2023 · 2 comments
Closed

msglist: Scroll-to-bottom button on message list #218

sirpengi opened this issue Jul 17, 2023 · 2 comments
Labels
a-msglist The message-list screen, except what's label:a-content
Milestone

Comments

@sirpengi
Copy link
Contributor

The message list should offer a clickable button that allows the user to scroll to the bottom (to the latest message). This button should hide itself when the user is at the bottom of the message list.


Notes

The icon used on web+mobile appear to be fa-chevron-down but that isn't available in the Materials icons (maybe linked to #200 )

The web version has additional logic that hides the button for keyboard users (see https://github.com/zulip/zulip/blob/1cd587d24be1d668fcf6d136172bfec69e35cb75/web/src/message_scroll.js) but I don't believe this is necessary/desired in the mobile app context

@gnprice
Copy link
Member

gnprice commented Jul 17, 2023

Thanks!

The icon used on web+mobile appear to be fa-chevron-down but that isn't available in the Materials icons (maybe linked to #200 )

Yeah. In that case just pick the closest approximation you can find in the Material icon set, and leave a TODO pointing at #200.

The web version has additional logic that hides the button for keyboard users […] but I don't believe this is necessary/desired in the mobile app context

Yeah, I agree.

@gnprice gnprice added the a-msglist The message-list screen, except what's label:a-content label Jul 17, 2023
@gnprice gnprice added this to the Launch milestone Jul 17, 2023
@sirpengi
Copy link
Contributor Author

This was implemented in #223
Thanks for everybody that helped out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-msglist The message-list screen, except what's label:a-content
Projects
Status: Done
Development

No branches or pull requests

2 participants