Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactions: Label text can linebreak sooner than necessary #433

Open
chrisbobbe opened this issue Dec 1, 2023 · 0 comments
Open

reactions: Label text can linebreak sooner than necessary #433

chrisbobbe opened this issue Dec 1, 2023 · 0 comments
Labels
a-design Visual and UX design a-msglist The message-list screen, except what's label:a-content
Milestone

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Dec 1, 2023

In a reaction chip in the message list (#410), the label with users' names (seen with UserSettings.displayEmojiReactionUsers) can get linebreaked for text wrapping sooner than is necessary:

image

In this example, it says:

Cordelia, Lear's daughter, You,
Polonius

when there is actually enough room to say

Cordelia, Lear's daughter, You, Polonius

This is a tradeoff we made consciously when implementing a reasonable layout for text emoji (where the button looks like ":tada: You, Polonius" instead of "🎉 You, Polonius"), when both the emoji text and the reaction label are long. See the first two pairs of screenshots at #410 (comment), which highlight the upside of that tradeoff. If we were less careful about text emoji, they could look extremely broken.

If we decide that the current issue is worth fixing, we should try to fix it without breaking text emoji. And we should keep in mind that UserSettings.emojiset isn't enough to determine whether we're going to show a text emoji, because we show text emoji for various error conditions, including when an image emoji fails to load (which we learn about especially late).

@chrisbobbe chrisbobbe added a-msglist The message-list screen, except what's label:a-content a-design Visual and UX design labels Dec 1, 2023
@chrisbobbe chrisbobbe added this to the Post-launch milestone Dec 1, 2023
@chrisbobbe chrisbobbe changed the title reactions: Label text can linebreak sooner than is strictly necessary reactions: Label text can linebreak sooner than necessary Dec 2, 2023
@gnprice gnprice modified the milestones: M6: Post-launch, M7: Future Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-design Visual and UX design a-msglist The message-list screen, except what's label:a-content
Projects
Status: No status
Development

No branches or pull requests

2 participants