You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gnprice opened this issue
May 10, 2024
· 0 comments
Labels
a-contentParsing and rendering Zulip HTML content, notably message contentsa-msglistThe message-list screen, except what's label:a-contentupstreamWould benefit from work in Flutter or another upstream
Since #587, we show videos in messages. We don't show them in the actual message list, though:
For an "embed" video (meaning it's on some external service, which Zulip web would embed in an iframe), we show a thumbnail, and tapping it opens the video as a link outside Zulip.
For an "inline" video (meaning the actual video is hosted on the Zulip server or somewhere it trusts), we show just a black box with a "play" icon, but tapping it opens the video directly in the app's own lightbox.
For embed videos, what we have is about as good as we can get. But for inline videos, we can in principle do better still:
First, it'd be good to show some kind of thumbnail or still frame from the video. These often help people see at a glance some idea of what the video is and decide if they want to look further.
Fancier than that, it'd be neat to buffer the beginning of the video when the message scrolls into view, before the user interacts with it. That way if they do decide to play it, the video can start immediately with no lag.
Early revisions of #587 had a version of this functionality, but it got removed before merge. For details, see:
a-contentParsing and rendering Zulip HTML content, notably message contentsa-msglistThe message-list screen, except what's label:a-contentupstreamWould benefit from work in Flutter or another upstream
Since #587, we show videos in messages. We don't show them in the actual message list, though:
For embed videos, what we have is about as good as we can get. But for inline videos, we can in principle do better still:
Early revisions of #587 had a version of this functionality, but it got removed before merge. For details, see:
The original PR description: content: Handle video previews #587 (comment)
This includes mention of a couple of bugs which we'd need to deal with, affecting
package:video_player
on iOS.More discussion of those bugs:
content: Handle video previews #587 (comment)
content: Handle video previews #587 (review)
content: Handle video previews #587 (comment)
content: Handle video previews #587 (comment)
The text was updated successfully, but these errors were encountered: