Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview inline videos directly in message list #656

Open
gnprice opened this issue May 10, 2024 · 0 comments
Open

Preview inline videos directly in message list #656

gnprice opened this issue May 10, 2024 · 0 comments
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents a-msglist The message-list screen, except what's label:a-content upstream Would benefit from work in Flutter or another upstream
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented May 10, 2024

Since #587, we show videos in messages. We don't show them in the actual message list, though:

  • For an "embed" video (meaning it's on some external service, which Zulip web would embed in an iframe), we show a thumbnail, and tapping it opens the video as a link outside Zulip.
  • For an "inline" video (meaning the actual video is hosted on the Zulip server or somewhere it trusts), we show just a black box with a "play" icon, but tapping it opens the video directly in the app's own lightbox.

For embed videos, what we have is about as good as we can get. But for inline videos, we can in principle do better still:

  • First, it'd be good to show some kind of thumbnail or still frame from the video. These often help people see at a glance some idea of what the video is and decide if they want to look further.
  • Fancier than that, it'd be neat to buffer the beginning of the video when the message scrolls into view, before the user interacts with it. That way if they do decide to play it, the video can start immediately with no lag.

Early revisions of #587 had a version of this functionality, but it got removed before merge. For details, see:

@gnprice gnprice added a-content Parsing and rendering Zulip HTML content, notably message contents a-msglist The message-list screen, except what's label:a-content labels May 10, 2024
@gnprice gnprice added this to the Post-launch milestone May 10, 2024
@gnprice gnprice modified the milestones: M6: Post-launch, M7: Future Nov 21, 2024
@gnprice gnprice added the upstream Would benefit from work in Flutter or another upstream label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents a-msglist The message-list screen, except what's label:a-content upstream Would benefit from work in Flutter or another upstream
Projects
Status: No status
Development

No branches or pull requests

1 participant