Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meet 64-bit requirement, by 2019-08 deadline #3323

Closed
gnprice opened this issue Feb 1, 2019 · 2 comments
Closed

Meet 64-bit requirement, by 2019-08 deadline #3323

gnprice opened this issue Feb 1, 2019 · 2 comments
Assignees
Labels
a-Android P0 critical Highest priority upstream: RN Issues related to an issue in React Native

Comments

@gnprice
Copy link
Member

gnprice commented Feb 1, 2019

Starting 2019-08-01, Google will require all published app updates to provide 64-bit versions of any native code.
https://android-developers.googleblog.com/2019/01/get-your-apps-ready-for-64-bit.html
https://developer.android.com/distribute/best-practices/develop/64-bit

We don't currently meet this, due entirely to a number of libraries built into React Native.

Google originally announced this requirement (and deadline) with nearly two years of lead time, in 2017:
https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html
and there's an issue open for it upstream:
facebook/react-native#2814

It's said to be fixed in master, so when we upgrade to v0.59 that will hopefully take care of it.

@gnprice gnprice added a-Android upstream: RN Issues related to an issue in React Native labels Feb 1, 2019
@gnprice gnprice added blocked on other work To come back to after another related PR, or some other task. P1 high-priority labels Jun 1, 2019
@gnprice gnprice added P0 critical Highest priority and removed P1 high-priority labels Jul 8, 2019
@gnprice
Copy link
Member Author

gnprice commented Jul 8, 2019

Bumping priority to P0, as this deadline is now a little over three weeks away.

@gnprice gnprice removed the blocked on other work To come back to after another related PR, or some other task. label Jul 25, 2019
@gnprice
Copy link
Member Author

gnprice commented Jul 25, 2019

#3399 is now done, and we're on RN v0.59! That unblocks this issue, and also makes it our one open issue at "P0 critical" priority.

I have a commit that should take care of this, based just on the change to the upstream template in the v0.59 upgrade. Will test and push soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-Android P0 critical Highest priority upstream: RN Issues related to an issue in React Native
Projects
None yet
Development

No branches or pull requests

1 participant