ZeroClipboard replaced by clipboard.js #7629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you! Just one request, is it possible for you to target the |
|
For sure. Since I merged from develop in this branch should I just start over with a new branch based off of master? |
|
Yeah, hopefully it's not too much work. If you can't sort it out, we're putting a patch out tomorrow anyway, but it would be awesome to get this out today. |
|
No trouble at all, I just wanted to make sure that's the best way to go about it so that a bunch of commits weren't merged prematurely into master. |
|
Right, yeah, we don't want that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in issue #7581.