Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure #1

Merged

Conversation

haennes
Copy link

@haennes haennes commented Sep 26, 2024

Seems to be related to this issue nix-community/naersk#323

@zvolin zvolin changed the base branch from master to fix/hm-options-with-flakes September 27, 2024 15:12
Copy link
Owner

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍 I changed base to my branch but in case you want that in master let me know

@zvolin zvolin merged commit 108936c into zvolin:fix/hm-options-with-flakes Sep 27, 2024
@haennes
Copy link
Author

haennes commented Sep 27, 2024

Thats fine :)
I will bump the your PR in the upstream as well, hopefully it will be merged eventually.

@zvolin
Copy link
Owner

zvolin commented Sep 27, 2024

Since I merged to the branch of that PR it should already be there

@zvolin
Copy link
Owner

zvolin commented Sep 27, 2024

Ah I guess I misunderstood :) yeah go for it, thanks

@haennes
Copy link
Author

haennes commented Sep 27, 2024

Additional question, I would like to confirm, that this is broken on the nix-community upstream, any Idea on how to do that?

@zvolin
Copy link
Owner

zvolin commented Sep 27, 2024

Do you mean to confirm that manix doesn't provide home-manager options?

@haennes
Copy link
Author

haennes commented Sep 27, 2024

No, i only got this build failure when (for example) doing nix run on this fork, if I do it on the nix-community/manix i dont get a failure. So I cant confirm my commit actually fixes a bug in the upstream.
I want to confirm that before giving another bump to the upstream PR.
Hope this makes it clear :)

@zvolin
Copy link
Owner

zvolin commented Sep 27, 2024

Interesting, I don't know. The only change I think could make a difference is

  release ? "24.05",

In upstream they have 23.05. my only guess is try changing only this in upstream and rebuild then

@haennes
Copy link
Author

haennes commented Sep 29, 2024

Just tried that, even when committing this doesn´t break the build.
Did you encounter a build-failure as well before you merged this?

@zvolin
Copy link
Owner

zvolin commented Sep 30, 2024

Nope, but I did this change quite some time ago, didn't try to build this since then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants