Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinging a node reports success even if the ping failed #3099

Closed
3 tasks done
jwparry opened this issue May 23, 2023 · 0 comments
Closed
3 tasks done

Pinging a node reports success even if the ping failed #3099

jwparry opened this issue May 23, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jwparry
Copy link

jwparry commented May 23, 2023

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Snap

Z-Wave JS UI version

8.15.0.f48c52b

ZwaveJS version

10.17.1

Describe the bug

Pinging a node returns the API call status (a green "API pingNode ended successfully" notification) even if the ping itself fails

To Reproduce

Ping a sleeping / failed node (eg one with its batteries removed)

Expected behavior

The notification indicates whether the ping itself succeeded or failed, with a separate indication if the internal API call fails

Additional context

No response
@jwparry jwparry added the bug Something isn't working label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwparry