Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): show when devices needs to be re-interviewed #3252

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Conversation

robertsLando
Copy link
Member

Fixes #3225

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6026174699

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 21.777%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ZwaveClient.ts 0 2 0.0%
src/components/nodes-table/nodes-table.js 0 2 0.0%
Totals Coverage Status
Change from base Build 6021752143: -0.005%
Covered Lines: 3845
Relevant Lines: 18673

💛 - Coveralls

@robertsLando robertsLando merged commit b2c7f84 into master Aug 30, 2023
@robertsLando robertsLando deleted the feat#3225 branch August 30, 2023 14:41
@snowmangh
Copy link

Hello Robert,

Nice feature but once I re-interview the node, the little blue icon does not go away. Maybe I am doing something wrong?

image

Home Assistant 2023.8.1
zwave-js-ui: 8.24.0.30eba25
zwave-js: 11.13.0
home id: 3589098709
home hex: 0xd5ed4cd5

@robertsLando
Copy link
Member Author

robertsLando commented Sep 4, 2023

@snowmangh You are right! I forgot to update the status when the interview is done, let me fix that asap :)

Here the PR: #3260

@coveralls
Copy link

coveralls commented Nov 18, 2024

Pull Request Test Coverage Report for Build 6026174699

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 21.777%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ZwaveClient.ts 0 2 0.0%
src/components/nodes-table/nodes-table.js 0 2 0.0%
Totals Coverage Status
Change from base Build 6021752143: -0.005%
Covered Lines: 3845
Relevant Lines: 18673

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show when devices needs to be reinterviewed
3 participants