Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vitejs and PWA support #3263

Merged
merged 15 commits into from
Sep 6, 2023
Merged

feat: vitejs and PWA support #3263

merged 15 commits into from
Sep 6, 2023

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Sep 5, 2023

This will speed up frontend a lot and make it also more lightweight 🎉

@robertsLando
Copy link
Member Author

robertsLando commented Sep 5, 2023

TODOs:

  • Proxy of websockets are not working: WebSocket proxy in middleware mode vitejs/vite#4124
  • SocketEvents cannot be imported from backend compiled directory server. Maybe switching to workspaces could be a better option
  • Check PWA is working
  • Try to lazy load components
  • Test everything works behind reverse proxy.
  • Check if ci/workflows needs to be fixed
  • Check pkg works

@robertsLando robertsLando marked this pull request as ready for review September 6, 2023 12:48
@robertsLando robertsLando changed the title chore: switch to vitejs feat: switch to vitejs Sep 6, 2023
@robertsLando robertsLando changed the title feat: switch to vitejs feat: vitejs and PWA support Sep 6, 2023
@robertsLando robertsLando merged commit d409051 into master Sep 6, 2023
@robertsLando robertsLando deleted the vitejs branch September 6, 2023 12:54
@coveralls
Copy link

coveralls commented Nov 18, 2024

Pull Request Test Coverage Report for Build 6097181584

Details

  • 0 of 200 (0.0%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 22.087%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/apis/ConfigApis.js 0 1 0.0%
src/lib/logger.js 0 1 0.0%
src/mixins/InstancesMixin.js 0 1 0.0%
src/main.js 0 3 0.0%
lib/SocketManager.ts 0 7 0.0%
src/components/nodes-table/nodes-table.js 0 7 0.0%
src/sw.js 0 9 0.0%
src/router/index.js 0 11 0.0%
src/lib/SocketEvents.js 0 30 0.0%
vite.config.js 0 130 0.0%
Totals Coverage Status
Change from base Build 6075568456: 0.3%
Covered Lines: 3783
Relevant Lines: 18107

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants