Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with WKWebView #22

Closed
askona opened this issue Feb 16, 2017 · 7 comments
Closed

Not working with WKWebView #22

askona opened this issue Feb 16, 2017 · 7 comments

Comments

@askona
Copy link
Contributor

askona commented Feb 16, 2017

HI! Plugin works incorrect when running on WKWebView, because of this condition
if (window.location.protocol === 'http:' || window.location.protocol === 'https:')
it detects app as running in browser. It would be great to make this condition more correct

@ihadeed ihadeed added the bug label Feb 16, 2017
@ihadeed
Copy link
Member

ihadeed commented Feb 17, 2017

@askona are you running on livereload?

@ihadeed ihadeed removed the bug label Feb 17, 2017
@askona
Copy link
Contributor Author

askona commented Feb 20, 2017

No, im not using livereload. Also, even with check above omitted, i have error
Not allowed to load local resource: file:///Users/admin/Library/Developer/CoreSimulator/Devices/471F448D-7CD6-4BBE-A9AC-56F27EFA934B/data/Containers/Data/Application/2459D1C3-4321-4D40-AFB6-52EA12C46A01/Library/Caches/image-loader-cache/1289029802

This issue was partially resolved , but some changes are required

@ihadeed
Copy link
Member

ihadeed commented Feb 20, 2017

What version of ionic-image-loader are you using? WKWebView support was only added in 1.3.0

@askona
Copy link
Contributor Author

askona commented Feb 21, 2017

I'm using 1.6.0

@askona
Copy link
Contributor Author

askona commented Feb 23, 2017

Livereload you mean this arrow-circled button "Reload" or "Refresh" in top left corner of Safari Web Inspector? image

@ihadeed
Copy link
Member

ihadeed commented Feb 23, 2017

@askona by livereload I meant ionic run ios --livereload. But I see you're not using that.

The WKWebView support that we currently have is for regular WKWebView, not the one modified by Ionic with the fix you linked to earlier.

I will review the PR you submitted and make sure it works for all cases, and then I'll merge.

@ihadeed ihadeed closed this as completed Mar 18, 2017
@ihadeed
Copy link
Member

ihadeed commented Mar 18, 2017

Merged the PR and now is available in version 1.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants