Skip to content

Commit

Permalink
fix(super-tabs): don't fire view events to fix change detection
Browse files Browse the repository at this point in the history
closes #30
  • Loading branch information
ihadeed committed May 1, 2017
1 parent c9168f8 commit 444f324
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/components/super-tabs/super-tabs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -426,18 +426,13 @@ export class SuperTabs implements OnInit, AfterContentInit, AfterViewInit, OnDes
*/
onTabChange(index: number) {
if (index <= this._tabs.length) {
this._tabs[this.selectedTabIndex].getActive()._didLeave();

this.selectedTabIndex = index;

this.linker.navChange('switch');

this.refreshTabStates();

const activeViewController = this._tabs[this.selectedTabIndex].getActive();

activeViewController && activeViewController._didEnter();

this.tabSelect.emit({
index,
id: this._tabs[index].tabId
Expand Down

0 comments on commit 444f324

Please sign in to comment.