Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing test to pass on 32 bit architecture. #245

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

simonrupf
Copy link
Contributor

Reduces large isize to remain below maximum for signed 32 bit int, resolves #243

Encountered this when trying to upgrade the alpine package.

Reduces large isize to remain below maximum for signed 32 bit int,
resolves 01mf02#243
Copy link
Contributor

@wader wader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@01mf02 maybe should have a 32bit CI build?

@01mf02
Copy link
Owner

01mf02 commented Dec 10, 2024

Thanks, @simonrupf!

@wader, I would be for such a 32-bit CI build, but I do not know how to do this while keeping build times small. If you have an idea about how to do it, I am all ears. :)

@wader
Copy link
Contributor

wader commented Dec 10, 2024

How tricky is it to cross compile with cargo? have to install some extra target for i386 etc? for fq's CI i cross compile to i386 but run on amd64, that has found similar issues.

@simonrupf
Copy link
Contributor Author

How tricky is it to cross compile with cargo?

It is not pretty, but doable with the github actions. This is for a somewhat different use case of building the same rust project for different platforms (aarch64 & x86_64 on Linux, as well x86_64 on Windows and universal binaries on MacOS) in a matrix job in parallel:
https://github.com/simonrupf/convert2json/blob/ceae230549c804780c6ef1712f9d4855bffa86a7/.github/workflows/release.yml#L28-L45

For the jaq use case you might want to start small and split the build job in rust.yml into a matrix of x86_64 & i686. If that performs adequately, expand it from there.

If you are interested, I could give the above a try? As a jaq user on alpine it is in my interest to ensure it works regression free... :-)

@wader
Copy link
Contributor

wader commented Dec 12, 2024

Ok i see, I defer to @01mf02 on what to do :) but if we could do something that don't affect CI build times much i would say it's worth it

@01mf02
Copy link
Owner

01mf02 commented Dec 13, 2024

@simonrupf, for release builds, we already cross-compile, see release.yml. If you are motivated to enable test builds on both x86_64 & i686, that would be much appreciated. :)

@01mf02 01mf02 merged commit 860a674 into 01mf02:main Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

math_rem test fails on the i686 target
3 participants