-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing test to pass on 32 bit architecture. #245
Conversation
Reduces large isize to remain below maximum for signed 32 bit int, resolves 01mf02#243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@01mf02 maybe should have a 32bit CI build?
Thanks, @simonrupf! @wader, I would be for such a 32-bit CI build, but I do not know how to do this while keeping build times small. If you have an idea about how to do it, I am all ears. :) |
How tricky is it to cross compile with cargo? have to install some extra target for i386 etc? for fq's CI i cross compile to i386 but run on amd64, that has found similar issues. |
It is not pretty, but doable with the github actions. This is for a somewhat different use case of building the same rust project for different platforms (aarch64 & x86_64 on Linux, as well x86_64 on Windows and universal binaries on MacOS) in a matrix job in parallel: For the jaq use case you might want to start small and split the build job in rust.yml into a matrix of x86_64 & i686. If that performs adequately, expand it from there. If you are interested, I could give the above a try? As a jaq user on alpine it is in my interest to ensure it works regression free... :-) |
Ok i see, I defer to @01mf02 on what to do :) but if we could do something that don't affect CI build times much i would say it's worth it |
@simonrupf, for release builds, we already cross-compile, see |
Reduces large isize to remain below maximum for signed 32 bit int, resolves #243
Encountered this when trying to upgrade the alpine package.