Add --argjson support #250
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wader
commented
Dec 25, 2024
| let v = lexer | ||
| .exactly_one(Val::parse) | ||
| .map_err(|e| Error::Parse(format!("cannot parse {s} as JSON: {e}"))); | ||
| Ok::<(std::string::String, Val), Error>((k.to_owned(), v?)) |
There was a problem hiding this comment.
My rust knowledge fails me here, compiler not happy about deriving type parameter E for Result without this. Also looking at the other code i guess maybe you would like to refactor this to share parsing of json somehow?
wader
commented
Dec 25, 2024
| let mut lexer = hifijson::SliceLexer::new(s.as_bytes()); | ||
| let v = lexer | ||
| .exactly_one(Val::parse) | ||
| .map_err(|e| Error::Parse(format!("cannot parse {s} as JSON: {e}"))); |
There was a problem hiding this comment.
Should probably skip or truncate s and mention k in error message
wader
commented
Dec 25, 2024
| "argjson" => { | ||
| let (name, value) = parse_key_val("--argjson", args)?; | ||
| self.argjson.push((name, value.into_string()?)); | ||
| } |
There was a problem hiding this comment.
As i understand code i cli just collects stings, reading files, parsing etc should happen in binds?
|
And hope your having great holidays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180