Migrate deprecated Pydantic function #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
However I can't seem to figure out why the tests fail |
|
There are still some legacy pydantic v1 interfaces used internally. To eliminate all the deprecation warnings, we will need to provide another abstraction layer to hide the diff. The test failed because we tested against both v1&v2. |
|
Thanks @kemingy. I'm not that familiar with the codebase and cannot invest time to implement this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydantic's
.schema()function is deprecated. This throws warnings and will eventually break when Pydantic v3.0 is used with Spectree. See the migration guide here.This PR fixes this issue.
Thanks!