Skip to content

Commit

Permalink
fix(commands/run): ensure configured client wrapper port is used
Browse files Browse the repository at this point in the history
Prior to this commit, using `WRAPPER_PORT` and changing it to a users needs
didn't have any effect as

a) the port has never been passed down to the Aragon client
b) Aragon client's script isn't prepared to retrieve values from the environment

This commit ensures that the port is set as an environment variable,
enabling Aragon client to take advantage of it.

Fixes aragon#198
  • Loading branch information
0x-r4bbit committed Sep 13, 2018
1 parent d0b4822 commit b05b316
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/commands/run.js
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ exports.handler = function ({
env: {
REACT_APP_ENS_REGISTRY_ADDRESS: ctx.ens,
BROWSER: 'none',
REACT_APP_PORT: WRAPPER_PORT
}
}

Expand Down Expand Up @@ -353,7 +354,7 @@ exports.handler = function ({
${chalk.bold('DAO address')}: ${ctx.daoAddress}
${(client !== false) ?
`Opening http://localhost:3000/#/${ctx.daoAddress} to view your DAO` :
`Opening http://localhost:${WRAPPER_PORT}/#/${ctx.daoAddress} to view your DAO` :
`Use "aragon dao <command> ${ctx.daoAddress}" to interact with your DAO`
}`)

Expand Down

0 comments on commit b05b316

Please sign in to comment.