-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support moonshot language model #223
Conversation
@0xMochan and @cvauclair Could you please review this change set? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I've highlighted several typos that may need fixing - once these are done, we can go ahead and get this merged!
Thanks for your feedback. They are typos and already fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the CI failed because there's a missing macro to force one of the trait implementations to be treated as Send by the WASM target.
Other than that, you just need to use cargo fmt
and I believe we should be able to get this merged immediately after!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - thank you for your patience!
Feature: integrate moonshot LLM so rig can leverage its model capability.
Test: