Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support moonshot language model #223

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

threewebcode
Copy link
Contributor

Feature: integrate moonshot LLM so rig can leverage its model capability.

Test:

cargo run --example agent_with_moonshot --features="derive"

Running basic agent with mootshot
Sure, let's dive into some humor!

Why don't scientists trust atoms? Because they make up everything!

And here's a classic one for you:

Why did the scarecrow win an award? Because he was outstanding in his field!

And for a bit of historical humor:

Why did the Roman Empire collapse? Because they couldn't conquer their fear of algebra!

I hope these jokes brought a smile to your face! If you'd like more, just let me know.

Running mootshot agent with context
A "glarb-glarb" is an ancient tool used by the ancestors of the inhabitants of planet Jiro to farm the land.


All agents ran successfully

@0xMochan 0xMochan self-requested a review January 20, 2025 16:10
@threewebcode
Copy link
Contributor Author

@0xMochan and @cvauclair Could you please review this change set?

@cvauclair cvauclair added this to the 2025-02-10 milestone Feb 3, 2025
@joshua-mo-143 joshua-mo-143 self-requested a review February 3, 2025 17:33
Copy link
Contributor

@joshua-mo-143 joshua-mo-143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've highlighted several typos that may need fixing - once these are done, we can go ahead and get this merged!

rig-core/examples/agent_with_moonshot.rs Outdated Show resolved Hide resolved
rig-core/examples/agent_with_moonshot.rs Outdated Show resolved Hide resolved
rig-core/examples/agent_with_moonshot.rs Outdated Show resolved Hide resolved
rig-core/examples/agent_with_moonshot.rs Outdated Show resolved Hide resolved
rig-core/examples/agent_with_moonshot.rs Outdated Show resolved Hide resolved
@threewebcode
Copy link
Contributor Author

Looks good to me. I've highlighted several typos that may need fixing - once these are done, we can go ahead and get this merged!

Thanks for your feedback. They are typos and already fixed.

Copy link
Contributor

@joshua-mo-143 joshua-mo-143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CI failed because there's a missing macro to force one of the trait implementations to be treated as Send by the WASM target.

Other than that, you just need to use cargo fmt and I believe we should be able to get this merged immediately after!

rig-core/src/providers/moonshot.rs Show resolved Hide resolved
rig-core/src/providers/moonshot.rs Outdated Show resolved Hide resolved
rig-core/src/providers/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@joshua-mo-143 joshua-mo-143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - thank you for your patience!

@joshua-mo-143 joshua-mo-143 merged commit 5c5fab8 into 0xPlaygrounds:main Feb 4, 2025
5 checks passed
This was referenced Feb 3, 2025
@threewebcode threewebcode deleted the feat-moonshot branch February 9, 2025 02:45
This was referenced Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants