feat: allow metadata field of ImportedBridges as hash #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToniRamirezM
approved these changes
Dec 5, 2024
goran-ethernal
approved these changes
Dec 5, 2024
…and MaxRetryAttemptsAfterError
|
joanestebanr
deleted the
feature/aggsender_imported_bridge_metadata_hash
branch
goran-ethernal
pushed a commit
that referenced
this pull request
Dec 6, 2024
The certificate field `metadata` of `BridgeExit` and `ImportedBridgeExit` instead of containing the full metadata are going to have the hash if length > 0. This behevaiour can be configured using a new config param `AggSender.BridgeMetadataAsHash` (by default: `true`) Other fixes: - Missing missing default values for `L1InfoTreeSync.RetryAfterErrorPeriod` and `MaxRetryAttemptsAfterError` - Improved estimateSize of certificate - Added e2e bridge messages but disabled because it keep failing (maybe we neeed another PR to fix that)
goran-ethernal
added a commit
that referenced
this pull request
Dec 9, 2024
The certificate field `metadata` of `BridgeExit` and `ImportedBridgeExit` instead of containing the full metadata are going to have the hash if length > 0. This behevaiour can be configured using a new config param `AggSender.BridgeMetadataAsHash` (by default: `true`) Other fixes: - Missing missing default values for `L1InfoTreeSync.RetryAfterErrorPeriod` and `MaxRetryAttemptsAfterError` - Improved estimateSize of certificate - Added e2e bridge messages but disabled because it keep failing (maybe we neeed another PR to fix that) Co-authored-by: Joan Esteban <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The certificate field
metadataofBridgeExitandImportedBridgeExitinstead of containing the full metadata are going to have the hash if length > 0.This behevaiour can be configured using a new config param
AggSender.BridgeMetadataAsHash(by default:true)Other fixes:
L1InfoTreeSync.RetryAfterErrorPeriodandMaxRetryAttemptsAfterError