Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: seq-sender latestVirtualTime #270

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

ToniRamirezM
Copy link
Contributor

Description

Gets latestVirtualTime from the ethtx manager db.

Fixes #247

@ToniRamirezM ToniRamirezM requested a review from a team January 20, 2025 14:26
@ToniRamirezM ToniRamirezM self-assigned this Jan 20, 2025
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As a side note (unrelated to this PR, but caught my attention), maybe we should consider setting the UTC time for the SentL1Timestamp and StatusTimestamp fields...?

@ToniRamirezM ToniRamirezM merged commit 57b4b15 into develop Jan 23, 2025
14 checks passed
@ToniRamirezM ToniRamirezM deleted the fix/latestVirtualTime branch January 23, 2025 11:59
ToniRamirezM added a commit that referenced this pull request Jan 23, 2025
ToniRamirezM added a commit that referenced this pull request Jan 23, 2025
* fix: seq-sender latestVirtualTime (#270)

* feat: update ethtx-manager lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants