feat: Add withdrawTo functionality to support exits to other addresses #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QEDK
commented
Nov 2, 2021
| require(_isContract(_tokenTemplate), "Token template is not contract"); | ||
| } | ||
|
|
||
| function withdraw(address childToken, uint256 id, uint256 amount, bytes memory data) public { |
There was a problem hiding this comment.
The changes are these 4 functions, and the internal _withdraw functions below. Had to reset the formatting here to be similar to all other contracts.
imyourm8
reviewed
Nov 3, 2021
| ); | ||
|
|
||
| // withdraw tokens | ||
| childTokenContract.burn(tokenId); |
There was a problem hiding this comment.
childTokenContract uses msg.sender internally? Other tokens use user's address to burn them, why does this contract uses the tunnel itself?
There was a problem hiding this comment.
We are using OpenZeppelin implementations of the ERC token contracts, in the case of ERC721 there is no such parameter, hence we don't have it either.
|
@QEDK can you please resolve the conflict? |
|
@jdkanani Done! 👌 |
|
Merging after a conversation with @imyourm8 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.