Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove contracts forge build hack #32

Merged
merged 3 commits into from
Apr 2, 2024
Merged

chore: remove contracts forge build hack #32

merged 3 commits into from
Apr 2, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Mar 27, 2024 •
edited
Loading

  • Remove the hack as the patch as already been merged into zkevm-contracts@develop.
  • Add a CI workflow to test the gas token feature.

@leovct leovct marked this pull request as ready for review March 27, 2024 17:17
@leovct leovct requested a review from a team March 28, 2024 15:52
@leovct leovct force-pushed the chore/remove-contracts-forge-build-hack branch from 281758a to 0a28115 Compare April 2, 2024 13:57
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@leovct leovct merged commit 06bbe82 into main Apr 2, 2024
5 checks passed
@leovct leovct deleted the chore/remove-contracts-forge-build-hack branch April 2, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praetoriansentry praetoriansentry praetoriansentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leovct @praetoriansentry