Fix empty forkid and parenthash in l2block read from datastream #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyrinCode
requested review from
revitteth,
hexoscott,
mandrigin and
eduadiez
as code owners
|
We require contributors/corporates @KyrinCode to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
|
@KyrinCode please could you try to bump these PRs to get the cla-bot to respond? I can't manually re-run it seems. |
|
With regards to this PR in particular - I'm going to come back to it later - need some time to check some things with it. So for now we will park if that's ok. |
KyrinCode
force-pushed
the
kyrin/fix-empty-forkid-parenthash-of-l2block-from-datastream
branch
from
da204d0 to
b6067e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1740
Original l2block in proto doesn't have forkid and parenthash. I believe this is a bug of implementation because the type
FullL2Blockread from datastream has these two fields and now they are both empty. After this fix, they will be written to datastream correctly, and ReadBatches in data_stream_server.go can read out all fields correctly.