This repository has been archived by the owner on Feb 17, 2025. It is now read-only.
Feature/json rpc ws #1445
Merged
Feature/json rpc ws #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tclemos
requested review from
ARR552,
cool-develope,
ToniRamirezM and
arnaubennassar
as code owners
tclemos
requested review from
kind84 and
Psykepro
and removed request for
ARR552 and
cool-develope
kind84
suggested changes
Dec 15, 2022
|
I'll merge this PR even with the e2e-group1 test failing because this is already failing in the develop branch and seems to be a mismatch between the image we have for l1 mock network and mock prover when running the tests. we need to fix this on develop branch. Issue #1470 was created to track this problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1408.
What does this PR do?
Adds support to Web Sockets to the RPC.
Reviewers