Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate zkevm-ethtx-manager v0.2.0 (sql lite storage) #84

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

Stefan-Ethernal
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal commented Oct 3, 2024

What does this PR do?

This PR integrates the zkevm-ethtx-manager v0.2.0 which relies on the SQL lite storage.

Reviewers

Main reviewers:

@Stefan-Ethernal Stefan-Ethernal self-assigned this Oct 3, 2024
@cla-bot cla-bot bot added the cla-signed label Oct 3, 2024
@Stefan-Ethernal Stefan-Ethernal force-pushed the CDK-519-integrate-zkevm-eth-txmanager branch 3 times, most recently from ee08d5d to 1d44f6c Compare October 4, 2024 14:30
@Stefan-Ethernal Stefan-Ethernal force-pushed the CDK-519-integrate-zkevm-eth-txmanager branch from 1d44f6c to a7db612 Compare October 4, 2024 14:35
Copy link

sonarqubecloud bot commented Oct 4, 2024

@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review October 4, 2024 14:52
Copy link

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the strategy

Copy link

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from minor comment

@Stefan-Ethernal Stefan-Ethernal merged commit 78d626e into develop Oct 7, 2024
6 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the CDK-519-integrate-zkevm-eth-txmanager branch October 7, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants