DIDComm alignment: expires_time & created_time #288
Conversation
src/iden3comm/handlers/payment.ts
Outdated
| @@ -310,6 +312,12 @@ export class PaymentHandler | |||
| paymentRequest: PaymentRequestMessage, | |||
| ctx: PaymentRequestMessageHandlerOptions | |||
| ): Promise<BasicMessage | null> { | |||
| if ( | |||
There was a problem hiding this comment.
A lot of code duplication. Can we do something like that:
package common
mustNotExpired = (obj: {expires_time?: number})) => {
if paymentRequest?.expires_time && paymentRequest.expires_time < Math.floor(Date.now() / 1000)
throw new Error
}Usage:
common.MustNotExpired(offer)
or
common.MustNotExpired(proposal)
...
My idea is have a utility function that consumes interface with optional field expires_time and does some logic
volodymyr-basiuk
changed the title
src/iden3comm/handlers/auth.ts
Outdated
| @@ -315,6 +316,7 @@ export class AuthHandler | |||
| ctx: AuthRespOptions | |||
| ): Promise<BasicMessage | null> { | |||
| const request = ctx.request; | |||
| verifyExpiresTime(response); | |||
There was a problem hiding this comment.
we need to add option to the handler - allowExpiredMessages.
source:
However, protocols can nuance this in their formal spec. For example, an online auction protocol might specify that timed out bids must be ignored instead of triggering a cancellation of the whole auction
| /** | ||
| * Basic message with all possible fields required | ||
| */ | ||
| export type RequiredBasicMessage = Omit<Required<BasicMessage>, 'created_time' | 'expires_time'> & { |
There was a problem hiding this comment.
Required makes all optional fields required, and we need all required except created_time and expires_time
There was a problem hiding this comment.
body is also can be optional. Why do we need this at all
No description provided.