feat: make TransactionResult serializable
#704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we merge this to |
|
Once 0xPolygonMiden/miden-base#1113 is merged, I think it is OK to merge this into |
tomyrd
force-pushed
the
tomyrd-serializable-tx-result
branch
from
25863d1 to
7642315
Compare
|
|
igamigo
approved these changes
Jan 28, 2025
Cargo.toml
Outdated
| @@ -20,8 +20,8 @@ repository = "https://github.com/0xPolygonMiden/miden-client" | |||
| [workspace.dependencies] | |||
| async-trait = "0.1" | |||
| miden-lib = { version = "0.7", default-features = false } | |||
| miden-objects = { version = "0.7", default-features = false } | |||
| miden-tx = { version = "0.7", default-features = false, features = ["async"] } | |||
| miden-objects = { version = "0.7.2", default-features = false } | |||
There was a problem hiding this comment.
We can drop the patch version from this and just cargo update miden-base dependencies
There was a problem hiding this comment.
also nit (for miden-tx as well), the extra space can be dropped as well:
Suggested change
| miden-objects = { version = "0.7.2", default-features = false } | |
| miden-objects = { version = "0.7", default-features = false } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.