Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integration tests with devnet #708

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

tomyrd
Copy link
Collaborator

@tomyrd tomyrd commented Jan 29, 2025

closes #707

@tomyrd tomyrd force-pushed the tomyrd-integration-tests-with-devnet branch from 83b2923 to 7c9eefe Compare January 29, 2025 15:28
@tomyrd tomyrd added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Jan 29, 2025
@tomyrd tomyrd marked this pull request as ready for review January 29, 2025 15:29
@tomyrd tomyrd force-pushed the tomyrd-integration-tests-with-devnet branch from 7c9eefe to 28080e4 Compare January 29, 2025 16:02
Copy link
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks


sync_cli(&temp_dir);

// Trying to init twice should result in an error
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this because it is already tested in test_init_with_params()

@igamigo igamigo merged commit 555b344 into main Jan 29, 2025
13 checks passed
@igamigo igamigo deleted the tomyrd-integration-tests-with-devnet branch January 29, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This PR does not require an entry in the `CHANGELOG.md` file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test setup fixes
2 participants