Standardise CI and Makefile across repositories #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
approved these changes
May 28, 2024
Makefile
Outdated
Comment on lines
55
to
61
| .PHONY: install-node | ||
| install-node: ## Installs node with testing feature enabled | ||
| cargo install --features testing --path bin/node | ||
|
|
||
| .PHONY: install-faucet | ||
| install-faucet: ## Installs faucet with testing feature enabled | ||
| cargo install --features testing --path bin/faucet |
There was a problem hiding this comment.
Should we have 2 versions of these commands? One for installing with testing feature and one without?
tomyrd
pushed a commit
that referenced
this pull request
Jun 3, 2024
* Replaced .toml by classical Makefile + updated CI * Fixed on: section * Updated Changelog * Cargo updated + added commands for install with testing
bobbinth
pushed a commit
that referenced
this pull request
Jun 10, 2024
* Replaced .toml by classical Makefile + updated CI * Fixed on: section * Updated Changelog * Cargo updated + added commands for install with testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I propose a standardisation of the CI and Makefile across Miden repositories.
With the following changes:
Once this first one is approved I will port it to the following repos:
Closes: #363