Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add init commands #392

Merged
merged 9 commits into from
Jun 28, 2024
Merged

feat: Add init commands #392

merged 9 commits into from
Jun 28, 2024

Conversation

tomyrd
Copy link
Collaborator

@tomyrd tomyrd commented Jun 25, 2024 •
edited
Loading

closes #385

This PR adds init commands in the node and faucet to generate default configuration files.

  • miden-node init creates both "miden-node.toml" and "genesis.toml".
  • miden-faucet init creates "miden-faucet.toml".

@tomyrd tomyrd changed the base branch from main to next June 25, 2024 19:32
@tomyrd tomyrd linked an issue Jun 25, 2024 that may be closed by this pull request
[Feature]: Add miden-node init and miden-faucet init commands #385
Closed
@tomyrd tomyrd force-pushed the tomyrd-init-commands branch from 0ab930f to eae1cf7 Compare June 26, 2024 17:54
@tomyrd tomyrd marked this pull request as ready for review June 26, 2024 20:53
bobbinth
bobbinth approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I've left a few minor nits inline. Once these are addressed, we can merge.

crates/utils/src/config.rs Outdated Show resolved Hide resolved
bin/faucet/README.md Outdated Show resolved Hide resolved
bin/node/src/commands/genesis/inputs.rs Outdated Show resolved Hide resolved
bobbinth
bobbinth approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

@bobbinth bobbinth merged commit ce4422a into next Jun 28, 2024
6 checks passed
@bobbinth bobbinth deleted the tomyrd-init-commands branch June 28, 2024 18:05
@bobbinth bobbinth mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add miden-node init and miden-faucet init commands
2 participants
@tomyrd @bobbinth