Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): cache sql statements #427

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

Mirko-von-Leipzig
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig commented Aug 1, 2024

Replace all conn.prepare with conn.prepare_cached and double the cache size limit from the default of 16 to 32. We currently have 22 different statements so this should be adequate for a while.

Closes #423.

@Mirko-von-Leipzig Mirko-von-Leipzig marked this pull request as ready for review August 1, 2024 14:53
Copy link
Contributor

@polydez polydez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left only one nit comment, but overall looks good to me, thanks!

crates/store/src/db/mod.rs Outdated Show resolved Hide resolved
@Mirko-von-Leipzig Mirko-von-Leipzig force-pushed the mirko-cache-sql-statements branch from 2193223 to eeb086f Compare August 1, 2024 15:46
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit afaa68f into next Aug 2, 2024
9 checks passed
@bobbinth bobbinth deleted the mirko-cache-sql-statements branch August 2, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants