ci: improve release devops #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dominik1999
approved these changes
Nov 6, 2024
| aws s3 cp ${{ env.node-package }} ${{ env.s3-path }}/${{ env.node-package }} | ||
| aws s3 cp ${{ env.node-faucet }} ${{ env.s3-path }}/${{ env.node-faucet }} | ||
|
|
||
| # TODO: does this fail if the files already exist? |
There was a problem hiding this comment.
Do we need the still as a ToDo?
There was a problem hiding this comment.
Yeah its something I'll have to try out at some stage - can't try it locally since its a command on a remote aws server.
Mirko-von-Leipzig
force-pushed
the
mirko-devops
branch
from
8fd2fd1 to
2edfd3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the deploy workflow to a more controlled manual flow.
It also distinguishes between creating a package, and bundling it into a release which simplifies the code overall.
Currently, deployment is automatic and occurs on each push for
devnetand on each release fortestnet. This doesn't quite suit our needs as often we want to release, test on devnet and only then deploy on testnet. Further, currently its impossible to create release artifacts without doing a deployment as well. This PR separates these concerns and allows for manually deploying.This PR also fixes some (as yet unknown) issues with the deployment scripts, causing deployments to not fully take (known to occur on at least devnet).
This PR is not yet complete.